Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-17830 BRS Alpha release page 2 #3988

Merged
merged 1 commit into from
Sep 4, 2024
Merged

CLDR-17830 BRS Alpha release page 2 #3988

merged 1 commit into from
Sep 4, 2024

Conversation

macchiati
Copy link
Member

@macchiati macchiati commented Aug 27, 2024 •
edited
Loading

Small updates from TC meeting.

CLDR-17830

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@macchiati macchiati requested review from AEApple and stenshamn August 27, 2024 21:55
AEApple
AEApple previously approved these changes Aug 28, 2024
View reviewed changes
@macchiati macchiati requested a review from AEApple September 4, 2024 14:58
@macchiati
Copy link
Member Author

Hi, I'd like to get these changes merged in, and then put it out to the TC for further refinements. Could you take a look?

@macchiati macchiati requested a review from srl295 September 4, 2024 21:23
srl295
srl295 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (will fixup syntax errs later)

@macchiati macchiati force-pushed the CLDR-17830-BRS-Alpha-release-page-2 branch from 53acbb1 to 9dd9a35 Compare September 4, 2024 22:52
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

AEApple
AEApple approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@AEApple AEApple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think we should still do another PR later and add the locale codes for all the locales which have increased coverage. Happy to put that in after this one merges if you'd like?

@srl295
Copy link
Member

srl295 commented Sep 4, 2024

Site issues cleared up in #4020

@macchiati macchiati merged commit a0935a5 into main Sep 4, 2024
13 of 14 checks passed
@macchiati macchiati deleted the CLDR-17830-BRS-Alpha-release-page-2 branch September 4, 2024 23:52
@macchiati
Copy link
Member Author

LGTM

I think we should still do another PR later and add the locale codes for all the locales which have increased coverage. Happy to put that in after this one merges if you'd like?

Yes, that's be great!

haytenf pushed a commit to haytenf/cldr that referenced this pull request Sep 17, 2024
@macchiati @haytenf
CLDR-17830 BRS Alpha release page 2 (unicode-org#3988)
d5404a9
conradarcturus pushed a commit that referenced this pull request Sep 25, 2024
@macchiati @conradarcturus
CLDR-17830 BRS Alpha release page 2 (#3988)
d1edaf9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AEApple AEApple AEApple approved these changes

@srl295 srl295 srl295 approved these changes

@stenshamn stenshamn Awaiting requested review from stenshamn

Assignees

@macchiati macchiati

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macchiati @srl295 @AEApple